Skip to content

fix: Prevent page create dialog from nesting when changing template #7609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bastianallgeier merged 2 commits into from
Sep 29, 2025
Merged

fix: Prevent page create dialog from nesting when changing template #7609

bastianallgeier merged 2 commits into from
Sep 29, 2025

Conversation

@distantnative
Copy link
Member

@distantnative distantnative commented Sep 29, 2025 •
edited by bastianallgeier
Loading

Changelog

🐛 Bug fixes

  • Reloading a dialog/drawer will no longer nest the new dialog/drawer but replace the previous one

For review team

  • Add lab and/or sandbox examples (wherever helpful)
  • Add changes & docs to release notes draft in Notion

@distantnative distantnative added this to the 5.1.2 milestone Sep 29, 2025
@distantnative distantnative self-assigned this Sep 29, 2025
@distantnative distantnative marked this pull request as ready for review September 29, 2025 10:14
@distantnative distantnative requested a review from a team September 29, 2025 10:14
@bastianallgeier
Copy link
Member

bastianallgeier commented Sep 29, 2025

Do you think we can add the change to the reload method to the patch release?

@distantnative
Copy link
Member Author

distantnative commented Sep 29, 2025 •
edited
Loading

@bastianallgeier I think so. It's basically a regression in 5.1.0 currently that reload() starts nesting dialogs (and probably long existing bugs for drawers).

@bastianallgeier bastianallgeier merged commit 21b0da4 into develop-patch Sep 29, 2025
4 checks passed
@bastianallgeier bastianallgeier deleted the fix/page-create-dialog-refresh branch September 29, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@distantnative distantnative

Labels

None yet

Milestone

5.1.2

Development

Successfully merging this pull request may close these issues.

3 participants

@distantnative @bastianallgeier