Admin passthrough removal#103
Merged
Bryan Malumphy (bmalumphy) merged 3 commits intomainfrom Jan 15, 2026
Merged
Conversation
Bryan Malumphy (bmalumphy)
requested a review
from Erik Everson (ErikEverson)
Contributor
🟢 Test Coverage Report -
|
| Metric | Coverage | Status |
|---|---|---|
| 🟢 Lines | 87.35% | green |
| 🟢 Statements | 87.35% | green |
| 🟢 Functions | 92.45% | green |
| 🟢 Branches | 86.1% | green |
📊 View Detailed Coverage Report
ℹ️ Coverage Thresholds
- 🟢 Excellent (≥ 80%)
- 🟡 Good (60-79%)
- 🟠 Fair (40-59%)
- 🔴 Poor (< 40%)
Contributor
🟢 Test Coverage Report -
|
| Metric | Coverage | Status |
|---|---|---|
| 🟢 Lines | 92.05% | green |
| 🟢 Statements | 92.05% | green |
| 🟢 Functions | 85.98% | green |
| 🟢 Branches | 88.64% | green |
📊 View Detailed Coverage Report
ℹ️ Coverage Thresholds
- 🟢 Excellent (≥ 80%)
- 🟡 Good (60-79%)
- 🟠 Fair (40-59%)
- 🔴 Poor (< 40%)
Contributor
|
| Severity | Count |
|---|---|
| 🔴 Critical | 0 |
| 🟠 High | 0 |
| 🟡 Medium | 1 |
| 🔵 Low | 0 |
| Total | 1 |
📋 Vulnerability Details
- CVE-2025-64718 (MEDIUM) in
js-yaml:3.14.2- Description: js-yaml is a JavaScript YAML parser and dumper. In js-yaml 4.1.0 and below, it's possible for an attacker to modify the prototype of the result of a parsed yaml document via prototype pollution ( proto ). All users who parse untrusted yaml documents may be impacted. The problem is patched in js-yaml 4.1.1. Users can protect against this kind of attack on the server by using node --disable-proto=delete or deno (in Deno, pollution protection is on by default).
- CVSS: 5.3
ℹ️ How to fix vulnerabilities
- Update vulnerable dependencies to patched versions
- Run
npm audit fixornpm audit fix --forcein the root directory - Check for alternative packages if updates aren't available
- Review and update your
package.jsonandpackage-lock.json
Contributor
|
| Severity | Count |
|---|---|
| 🔴 Critical | 0 |
| 🟠 High | 0 |
| 🟡 Medium | 1 |
| 🔵 Low | 0 |
| Total | 1 |
📋 Vulnerability Details
- CVE-2025-64718 (MEDIUM) in
js-yaml:3.14.2- Description: js-yaml is a JavaScript YAML parser and dumper. In js-yaml 4.1.0 and below, it's possible for an attacker to modify the prototype of the result of a parsed yaml document via prototype pollution ( proto ). All users who parse untrusted yaml documents may be impacted. The problem is patched in js-yaml 4.1.1. Users can protect against this kind of attack on the server by using node --disable-proto=delete or deno (in Deno, pollution protection is on by default).
- CVSS: 5.3
ℹ️ How to fix vulnerabilities
- Update vulnerable dependencies to patched versions
- Run
npm audit fixornpm audit fix --forcein the root directory - Check for alternative packages if updates aren't available
- Review and update your
package.jsonandpackage-lock.json
Collaborator
Erik Everson (ErikEverson)
left a comment
Erik Everson (ErikEverson)
left a comment
There was a problem hiding this comment.
One thing
Comment on lines
+147
to
+152
| func getAdminAccess(email: String) async throws -> Bool { | ||
| return try await p2pStore.ditto.store.execute( | ||
| query: "SELECT * FROM `roles` WHERE email = :email", | ||
| arguments: ["email": email] | ||
| ).items.count > 0 | ||
| } |
Collaborator
There was a problem hiding this comment.
We probably want this to be an observer so then someone does not have to kill the app and load it again if they get admin access added to their account.
Collaborator
There was a problem hiding this comment.
Also we will need the roles collection to have a subscription set up. That may already be done somewhere else
Bryan Malumphy (bmalumphy)
requested a review
from Erik Everson (ErikEverson)
Erik Everson (ErikEverson)
approved these changes
Jan 15, 2026
| return !roles.isEmpty | ||
| } | ||
| private var rolesCancellable: AnyCancellable? | ||
| private var roles: [AdminRole] = [] |
Collaborator
There was a problem hiding this comment.
Might need to be published
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.