Conversation
We use a configuration option that isn't recognized by earlier versions (Metrics/BlockLength/AllowedMethods).
Also, suppress the warning about MFA publishing requirement opt-in. We might want to revisit in the future, but for now, the gems are automatically published by CI.
kgilpin
approved these changes
Oct 11, 2022
|
🎉 This PR is included in version 0.93.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we want to have recording by default, I think this makes more sense and is what user would expect: appmap is enabled by default whenever tests are run, regardless of environment variables (which might not even be set, even for example for rails — it only uses them as one input to determine environment).
It can still be disabled with
APPMAP=falseorAPPMAP_RECORD_RSPEC=false.Fixes #288