Rewrite pay_ln_address.js to TypeScript #383
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolznz
reviewed
May 8, 2025
| import { stdin as input, stdout as output } from "node:process"; | ||
|
|
||
| // ⚠️ Using locally built SDK for testing — run `pnpm build` before running this example. | ||
| import { LN, USD } from "../../dist/index.module.js"; |
There was a problem hiding this comment.
We want to avoid this as it defeats the whole purpose of moving to typescript. We either need to import the actual typescript files or import from @getalby/sdk and add a package.json to the examples folder.
|
Alright. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is based on my earlier discussion with @rolznz regarding rewriting each example file in TypeScript and submitting them as individual PRs. The goal is to:
Changes in This PR:
Renamed
pay_ln_address.js→pay_ln_address.tsRewrote the file in TypeScript, using:
index.module.js)LNClientfromdist/index.d.tsPreserved existing functionality while improving readability and type safety
Notes:
@rolznz — starting with this file as the first step. Let me know if the structure, import style, and formatting align with your expectations. I’d be happy to adjust anything as needed so we can use this as the reference approach for the remaining conversions.
Looking forward to your feedback!