Skip to content

CI broken, due to MSRV of home crate. #1283

@michaelkirk

Description

@michaelkirk

CI is currently broken, due to an MSRV bump of the home crate.

Our direct dependency proj has a transitive dependency on the which crate, which in turn depends on this home crate.

Someone recently opened harryfei/which-rs#104, which well summarizes the issue

home is not intended for external use (outside of cargo). home has cargo's automatic MSRV-3 policy, which causes build failures for downstream dependants who check against their MSRV and where the package resolver is not MSRV-aware.

They proposed a fix just yesterday: harryfei/which-rs#105

env-home is a better solution:

As a side note, I just learned that rust 2024 intends to have an MSRV aware package resolution, yay!

We can either:

  • wait to see if this fix gets merged soon
  • pin to an older version of home
  • abandon our 6+ month MSRV support window (not my preferred option)

All this to read a couple of env vars 😆

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions