Skip to content

Feature/UI abstraction #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 27, 2024
Merged

Feature/UI abstraction #81

merged 4 commits into from
Feb 27, 2024

Conversation

benjaminye
Copy link
Contributor

@benjaminye benjaminye commented Feb 27, 2024 •
edited
Loading

This PR introduces UI abstract class that replaces all instances where print to stdout is required. This cleans up current code where print is directly called and centralize all printed messages. This PR also paves the way for other future (G)UI implementations.

  • Defined UI abstract class
  • Implemented RichUI that handles current rich console prints
  • Refactored all existing modules to use RichUI implementation

@benjaminye benjaminye requested a review from RohitSaha February 27, 2024 02:05
@benjaminye benjaminye added the enhancement New feature or request label Feb 27, 2024
@RohitSaha RohitSaha merged commit 387916f into main Feb 27, 2024
@benjaminye benjaminye deleted the feature/ui-abstraction branch March 4, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RohitSaha RohitSaha Awaiting requested review from RohitSaha

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjaminye @RohitSaha