[OpenCage] Locality #445
Merged
[OpenCage] Locality #445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
poke @mtmail If it's ok for you, I'll add some tests |
|
Sure. Thanks. Fyi, This is a list of aliases we use for our address formatting. https://github.com/OpenCageData/address-formatting/blob/master/conf/components.yaml |
|
ok thx :) |
|
poke @geocoder-php/geocoder |
| protected function guessBestComponent(array $components, array $keys) | ||
| { | ||
| foreach ($keys as $key) { | ||
| if (isset($components[$key]) && !empty($components[$key])) { |
There was a problem hiding this comment.
the isset check is superfluously.
|
Looks good 👍 |
|
Small CS stuffs but overall 👍 |
|
thanks @nicolassing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use city, town village or hamlet as locality