[Google Maps] Added missing nullable return type #1065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes Google Maps does not return a Plus Code.
PoC:
{"query":"[object] (Geocoder\\Query\\GeocodeQuery: GeocodeQuery: {\"text\":\"Port of Ijmuiden, North Holland, Netherlands, Port Ijmuiden Port\",\"bounds\":\"null\",\"locale\":null,\"limit\":5,\"data\":{\"mode\":\"search\",\"fields\":\"formatted_address, geometry, icon, name, place_id, plus_code, types\"}})"}
The first 2 results have a PlusCode but the rest do not, which generates an exception.
|
Hello @jackff87 , Thanks for your PR ! |
jbelien
changed the title
Nyholm
approved these changes
Jun 25, 2020
| @@ -194,7 +194,7 @@ public function withIcon(string $icon = null) | |||
| /** | |||
| * @return PlusCode|null | |||
| */ | |||
| public function getPlusCode(): PlusCode | |||
| public function getPlusCode(): ?PlusCode | |||
There was a problem hiding this comment.
This is a bugfix. The docs clearly states what the return type should be.
|
I'll merge this PR after dropping PHP 7.0 support (see #1066) 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes Google Maps does not return a Plus Code.
PoC:
{"query":"[object] (Geocoder\Query\GeocodeQuery: GeocodeQuery: {"text":"Port of Ijmuiden, North Holland, Netherlands, Port Ijmuiden Port","bounds":"null","locale":null,"limit":5,"data":{"mode":"search","fields":"formatted_address, geometry, icon, name, place_id, plus_code, types"}})"}
The first 2 results have a PlusCode but the rest do not, which generates an exception.