earcut on a worker!! #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebarron
commented
Nov 30, 2023
examples/polygon/app.tsx
Outdated
| pickable: true, | ||
| autoHighlight: true, | ||
| }) | ||
| workerUrl: new URL( | ||
| "https://gist.githubusercontent.com/kylebarron/0553b763d118bed6bad48407e9729376/raw/698855d8b237b26af65e2199a4f7914af8e203cf/earcut-worker.js", |
There was a problem hiding this comment.
I was getting issues around "failed to construct worker, script cannot be accessed from origin", and wasn't sure if I was doing something wrong on localhost
There was a problem hiding this comment.
ref https://stackoverflow.com/questions/21913673/execute-web-worker-from-different-origin, https://stackoverflow.com/questions/67326425/construct-worker-from-script-loaded-from-different-origin
Apparently you just can't instantiate a worker cross origin...? That's annoying, but we fetch the worker directly now.
kylebarron
commented
Nov 30, 2023
kylebarron
commented
Nov 30, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses geoarrow/geoarrow-js#20; uses a threadpool for earcut by default!