Skip to content

Support outputting debug log for min/max-DPS runs#632

Merged
srliao merged 2 commits intogenshinsim:nextfrom
isundaylee:next-minmaxdebug
Jul 11, 2022
Merged

Support outputting debug log for min/max-DPS runs#632
srliao merged 2 commits intogenshinsim:nextfrom
isundaylee:next-minmaxdebug

Conversation

@isundaylee
Copy link
Contributor

@isundaylee isundaylee commented Jul 11, 2022

If the new CLI option --debugMinMax is given, will additionally output min/max-DPS runs' debug logs in debug_min_dps_run and debug_max_dps_run JSON fields in the output.

Tested with doing a sim and tallying up the damage from the 3 debug runs:

$ tools/gcsim_tools.py show-damages /tmp/gcsim.out.gz.gz | pc -1 | get_sum
698147

$ tools/gcsim_tools.py show-damages /tmp/gcsim.out.gz.gz --debug-log-flavor debug_min_dps_run | pc -1 | get_sum
423780

$ tools/gcsim_tools.py show-damages /tmp/gcsim.out.gz.gz --debug-log-flavor debug_max_dps_run | pc -1 | get_sum
809334

@srliao
Copy link
Contributor

srliao commented Jul 11, 2022

now we just need ui support for this. thanks for the pr =)

@srliao srliao merged commit d272cce into genshinsim:next Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants