Support outputting debug log for min/max-DPS runs#632
Merged
srliao merged 2 commits intogenshinsim:nextfrom Jul 11, 2022
Merged
Support outputting debug log for min/max-DPS runs#632srliao merged 2 commits intogenshinsim:nextfrom
srliao merged 2 commits intogenshinsim:nextfrom
Conversation
Contributor
|
now we just need ui support for this. thanks for the pr =) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the new CLI option
--debugMinMaxis given, will additionally output min/max-DPS runs' debug logs indebug_min_dps_runanddebug_max_dps_runJSON fields in the output.Tested with doing a sim and tallying up the damage from the 3 debug runs: