Fix xilonen geo sampler being active if all samplers were converted#2332
Merged
shizukayuki merged 1 commit intogenshinsim:mainfrom Feb 6, 2025
Merged
Fix xilonen geo sampler being active if all samplers were converted#2332shizukayuki merged 1 commit intogenshinsim:mainfrom
shizukayuki merged 1 commit intogenshinsim:mainfrom
Conversation
Contributor
Author
|
I over-check sampler activity to try to "future-proof" edits. Probably not needed; either the call to activeGeoSampler() or the areas where the method is called could be reverted with no loss in functionality. I chose to use checks against c.samplersConverted < or >= 3, this could be replaced with checks against cshredElements[attributes.Geo] if desired. |
shizukayuki
changed the title
shizukayuki
added
kind: bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://discord.com/channels/845087716541595668/1336939788925931561