Skip to content

Add Pyro MC and Skirk's Story buffs#2329

Merged
imring merged 20 commits intogenshinsim:mainfrom
just1ce5:pyromc-dev
Sep 2, 2025
Merged

Add Pyro MC and Skirk's Story buffs#2329
imring merged 20 commits intogenshinsim:mainfrom
just1ce5:pyromc-dev

Conversation

@just1ce5
Copy link
Contributor

@just1ce5 just1ce5 commented Jan 29, 2025 •
edited by Charlie-Zheng
Loading

  • New character package
  • Config in character package
  • Run pipeline with added config (generates character curve, talent stats, .generated.json files)
  • Character key
  • Shortcuts for character key
  • Update mode_gcsim.js with shortcuts for syntax highlighting
  • Add Character package to imports
  • Normal Attack
  • Charge Attack / Aimed Shot
  • Skill
  • Burst
  • A1
  • A4
  • C1
  • C2
  • C3
  • C4
  • C5
  • C6
  • Other necessary talents (custom dash/jump, low/high plunge, ...)
  • Hitlag
  • ICD
  • StrikeType
  • PoiseDMG (blunt attacks only for now)
  • Hitboxes
  • Attack durability
  • Particles
  • Frames
  • Update documentation
  • Xingqiu/Yelan N0 (optional)
  • Xianyun Plunge (optional)

@imring imring added area: internal Related to artifacts/weapons/characters kind: game alignment Missing mechanic from the game labels Jan 30, 2025
@Fred-Redstone-2
Copy link

Fred-Redstone-2 commented Jun 24, 2025

Any updates on that?

@ange1o5
Copy link
Contributor

ange1o5 commented Jun 24, 2025

Any updates on that?

Nope, frames are needed

@just1ce5
Copy link
Contributor Author

just1ce5 commented Aug 18, 2025

I need help with the following stuff:

  • Someone who can has access to datamine please confirm the AoE of skills and update documentation.

@Charlie-Zheng
Copy link
Collaborator

Charlie-Zheng commented Aug 19, 2025

Do you want to add the Skirk story quest buffs here as well?

Charlie-Zheng
Charlie-Zheng requested changes Aug 19, 2025
View reviewed changes
@just1ce5
Copy link
Contributor Author

just1ce5 commented Aug 25, 2025

Do you want to add the Skirk story quest buffs here as well?

I did not plan to, but I'll try

@just1ce5 just1ce5 changed the title Add Pyro MC Add Pyro MC and Skirk's Story buffs Aug 25, 2025
Charlie-Zheng
Charlie-Zheng previously approved these changes Aug 31, 2025
View reviewed changes
@Charlie-Zheng Charlie-Zheng dismissed their stale review August 31, 2025 22:12

I noticed that frames sheet isn't link

@Charlie-Zheng
Added frames sheet
45981f8
@Charlie-Zheng
Added lumine pyro plunge
a58f0da
@Charlie-Zheng
Fix golangci-plus
587653f
@Charlie-Zheng
Merge branch 'gcsim_main' into pyromc
03eae84 
# Conflicts:
#	internal/services/assets/avatars_gen.go
#	pkg/simulation/imports_char_gen.go
#	ui/packages/docs/src/components/AoE/character_data.json
@imring imring merged commit d1d1fa1 into genshinsim:main Sep 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Charlie-Zheng Charlie-Zheng Charlie-Zheng approved these changes

Assignees

No one assigned

Labels

area: internal Related to artifacts/weapons/characters kind: game alignment Missing mechanic from the game

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@just1ce5 @Fred-Redstone-2 @ange1o5 @Charlie-Zheng @imring