Skip to content

Conversation

@giswqs
Copy link
Member

@giswqs giswqs commented Oct 2, 2025

Fix #2310

Removing the duplicate functions introduced by #2287

@giswqs giswqs requested a review from Copilot October 2, 2025 20:44
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes duplicate function definitions that were accidentally introduced in a previous pull request (#2287). The change focuses on cleaning up the codebase by eliminating redundant implementations.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@giswqs giswqs requested a review from schwehr October 2, 2025 20:44
@github-actions
Copy link

github-actions bot commented Oct 2, 2025

@github-actions github-actions bot temporarily deployed to pull request October 2, 2025 20:51 Inactive
@giswqs giswqs merged commit c59c36c into master Oct 6, 2025
15 checks passed
@giswqs giswqs deleted the duplicates branch October 6, 2025 17:57
@schwehr
Copy link
Collaborator

schwehr commented Oct 8, 2025

Sorry I was slow on the review. Thanks for fixing this!

Copy link
Collaborator

@schwehr schwehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the fact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

timelapse.py: Two copies of def add_sample_markers_to_gif

2 participants