Skip to content

fix: validate To BCD scheme option#2496

Open
puneetdixit200 wants to merge 1 commit into
gchq:masterfrom
puneetdixit200:codex/fix-to-bcd-invalid-scheme
Open

fix: validate To BCD scheme option#2496
puneetdixit200 wants to merge 1 commit into
gchq:masterfrom
puneetdixit200:codex/fix-to-bcd-invalid-scheme

Conversation

@puneetdixit200

Copy link
Copy Markdown

Description

Adds validation for the To BCD scheme argument so malformed recipe URLs with an empty scheme return a controlled operation error instead of an uncaught TypeError.

Existing Issue

Closes #2488

Screenshots

N/A

AI disclosure

I used OpenAI Codex to inspect the existing BCD operation/tests, add the regression test, and run verification. I reviewed the code and test output.

Test Coverage

  • node --no-warnings --no-deprecation --openssl-legacy-provider --input-type=module -e 'import TestRegister from "./tests/lib/TestRegister.mjs"; await import("./tests/operations/tests/BCD.mjs"); const results = await TestRegister.runTests(); const failed = results.filter(r => r.status !== "passing"); console.log(JSON.stringify(failed.map(r => ({name: r.test.name, status: r.status, output: r.output})), null, 2)); process.exit(failed.length ? 1 : 0);'
  • npm test
  • npm run lint
  • git diff --check

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Deepak kudi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(To BCD): TypeError can't access property

3 participants