-
Notifications
You must be signed in to change notification settings - Fork 860
ENH: add graph validation function #1317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+579
−94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1317 +/- ##
==========================================
+ Coverage 98.47% 98.57% +0.09%
==========================================
Files 24 25 +1
Lines 2425 2591 +166
==========================================
+ Hits 2388 2554 +166
Misses 37 37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Jun 23, 2025
…generic ValueError
3 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a private internal
_validatemodule and exposes public functions via theconvertmodule. This allows users to validate their graphs and GeoDataFrames and, in turn, will make it easier for people manually create their own from raw data while ensuring it has all the required attributes that OSMnx expects (and adds automatically in thegraph_from_xfunctions).This ensures that all the "expected standard structure" exists in a graph if you've created it from raw data, hopefully making it much easier for users to do so without guessing at a checklist themselves.
_validatemodule with validation functionalityvalidate_graph,validate_node_edge_gdfs, andvalidate_features_gdffunctions via theconvertmoduleSee also #1314 and #1234.