Skip to content

Conversation

@gboeing
Copy link
Owner

@gboeing gboeing commented Jun 19, 2025

This PR adds a private internal _validate module and exposes public functions via the convert module. This allows users to validate their graphs and GeoDataFrames and, in turn, will make it easier for people manually create their own from raw data while ensuring it has all the required attributes that OSMnx expects (and adds automatically in the graph_from_x functions).

This ensures that all the "expected standard structure" exists in a graph if you've created it from raw data, hopefully making it much easier for users to do so without guessing at a checklist themselves.

  • add private internal _validate module with validation functionality
  • expose public validate_graph, validate_node_edge_gdfs, and validate_features_gdf functions via the convert module

See also #1314 and #1234.

@codecov
Copy link

codecov bot commented Jun 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.57%. Comparing base (f98bae6) to head (5fb2de1).
⚠️ Report is 38 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1317      +/-   ##
==========================================
+ Coverage   98.47%   98.57%   +0.09%     
==========================================
  Files          24       25       +1     
  Lines        2425     2591     +166     
==========================================
+ Hits         2388     2554     +166     
  Misses         37       37              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gboeing gboeing changed the base branch from main to v2.1 August 11, 2025 18:29
@gboeing gboeing mentioned this pull request Aug 11, 2025
Base automatically changed from v2.1 to main December 12, 2025 21:52
@gboeing gboeing changed the title [WIP] ENH: add graph validation function ENH: add graph validation function Dec 16, 2025
@gboeing gboeing merged commit 4afd7dd into main Dec 16, 2025
10 checks passed
@gboeing gboeing deleted the validate branch December 16, 2025 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants