gatsby-plugin-manifest omits asset prefix in manifest.webmanifest icon URLs #25207
Description
Description
Currently, gatsby-plugin-manifest is prefixing the URL to the icons in manifest.webmanifest with the pathPrefix config value only. I would assume, like other assets, the icons in the manfiest should be prefixed with assetPrefix followed by pathPrefix. Weirdly though, the favicon and other app icons that are inserted the document's <head> are prefixed with assetPrefix and pathPrefix as expected so there's an inconsistency between icon URLs in gatsby's html document and ones inside manifest.webmanifest.
Steps to reproduce
See https://github.com/disintegrator/gatsby-25207
Expected result
- URL of icons added to the
<head>of pages are prefixed withassetPrefixand thenpathPrefix. - URL of favicon and inside of
manifest.webmanifestare prefixed withassetPrefixand thenpathPrefix.
Actual result
✅ (working) URL of icons added to the <head> of pages are prefixed with assetPrefix and then pathPrefix.
❌ (not working) URL of favicon and inside of manifest.webmanifest are only prefixed with pathPrefix .
Environment
System:
OS: macOS 10.15.5
CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
Shell: 5.7.1 - /usr/local/bin/zsh
Binaries:
Node: 12.18.1 - /var/folders/11/zcvk9j4j7rd_dj0t5hcv9wc80000gp/T/yarn--1592842676680-0.26237458001029235/node
Yarn: 1.22.4 - /var/folders/11/zcvk9j4j7rd_dj0t5hcv9wc80000gp/T/yarn--1592842676680-0.26237458001029235/yarn
npm: 6.14.5 - /usr/local/bin/npm
Languages:
Python: 2.7.16 - /usr/bin/python
Browsers:
Chrome: 83.0.4103.106
Firefox: 77.0.1
Safari: 13.1.1
npmPackages:
gatsby: ^2.23.3 => 2.23.3
gatsby-image: ^2.4.7 => 2.4.7
gatsby-plugin-manifest: ^2.4.11 => 2.4.11
gatsby-plugin-offline: ^3.2.9 => 3.2.9
gatsby-plugin-react-helmet: ^3.3.4 => 3.3.4
gatsby-plugin-sharp: ^2.6.11 => 2.6.11
gatsby-source-filesystem: ^2.3.11 => 2.3.11
gatsby-transformer-sharp: ^2.5.5 => 2.5.5
npmGlobalPackages:
gatsby-cli: 2.7.15