Conversation
garutilorenzo
left a comment
garutilorenzo
left a comment
There was a problem hiding this comment.
I don't understand this piece of code:
%{ if install_argocd_image_updater }
if [[ "$first_last" == "first" ]]; then
kubectl apply -n argocd -f
https://raw.githubusercontent.com/argoproj-labs/argocd-image-updater/${argocd_image_updater_release}/manifests/install.yaml
fi
%{ endif }
argocd_image_updater can be installed without argo cd?
Maybe this if can be placed on line 205?
| %{ if install_argocd_image_updater } | ||
| if [[ "$first_last" == "first" ]]; then | ||
| kubectl apply -n argocd -f | ||
| https://raw.githubusercontent.com/argoproj-labs/argocd-image-updater/${argocd_image_updater_release}/manifests/install.yaml | ||
| fi | ||
| %{ endif } |
There was a problem hiding this comment.
Why this part is duplicated? The image updater is installed on line 206..
The argocd image updater can be installed without argocd?
There was a problem hiding this comment.
Ah my bad, yeah, it can be installed and used to only update the image ref on the repo, but it probably doesn't make sense, let me move that
garutilorenzo
left a comment
garutilorenzo
left a comment
There was a problem hiding this comment.
I think we can save an If in files/k3s-install-server.sh
%{ if install_argocd }
if [[ "$first_last" == "first" ]]; then
kubectl create namespace argocd
kubectl apply -n argocd -f https://raw.githubusercontent.com/argoproj/argo-cd/${argocd_release}/manifests/install.yaml
%{ if install_argocd_image_updater }
kubectl apply -n argocd -f https://raw.githubusercontent.com/argoproj-labs/argocd-image-updater/${argocd_image_updater_release}/manifests/install.yaml
%{ endif }
fi
For the lifecycle in template.tf, This is OK for the "always free account" but in a "on demand/paid account" if the metadata change I want that terraform update my template and then my running instances.
…hanges. This PR is going out of scope. To fix the template 'issue' in the always free account we need to open a new PR.
garutilorenzo
left a comment
garutilorenzo
left a comment
There was a problem hiding this comment.
Made some changes. Removed the template fix because this PR is going out of the scope (add argocd). If is ok for you I will merge the PR.
Yup, feel free to merge it anytime 👍 |
2 participants
Hi 👋,
I added argocd to the install script, tested on my cluster and everything worked fine, I wanted to migrate everything to helm but didn't want to change everything without knowing if you are planning to switch to helm at some point? if not that's ok as well, awesome module btw, it works great so far.
Regards.
Gabriel.