Skip to content

Remove extension configmap permissions #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vpnachev merged 1 commit into from
Apr 23, 2025
Merged

Remove extension configmap permissions #308

vpnachev merged 1 commit into from
Apr 23, 2025

Conversation

@dimityrmirchev
Copy link
Member

@dimityrmirchev dimityrmirchev commented Apr 15, 2025

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

The extension no longer has permissions over configmaps as it does not require such access.

@dimityrmirchev dimityrmirchev requested a review from a team as a code owner April 15, 2025 12:49
@gardener-robot gardener-robot added needs/review Needs review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 15, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 15, 2025
@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Apr 22, 2025
@gardener-robot
Copy link
Contributor

gardener-robot commented Apr 22, 2025

@dimityrmirchev You need rebase this pull request with latest master branch. Please check.

@vpnachev
Copy link
Member

vpnachev commented Apr 22, 2025

/needs rebase

@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 22, 2025
vpnachev
vpnachev approved these changes Apr 23, 2025
View reviewed changes
Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/rebase Needs git rebase needs/review Needs review labels Apr 23, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 23, 2025
@vpnachev vpnachev merged commit e3c87db into gardener:master Apr 23, 2025
9 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vpnachev vpnachev vpnachev approved these changes

Assignees

No one assigned

Labels

needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/closed Issue is closed (either delivered or triaged)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dimityrmirchev @gardener-robot @vpnachev @gardener-robot-ci-1 @gardener-robot-ci-3