Skip to content

Fix the service annotation to scrape extension metrics in the seed #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dimityrmirchev merged 2 commits into from
Feb 18, 2025
Merged

Fix the service annotation to scrape extension metrics in the seed #290

dimityrmirchev merged 2 commits into from
Feb 18, 2025

Conversation

@vicwicker
Copy link
Member

@vicwicker vicwicker commented Feb 17, 2025 •
edited
Loading

What this PR does / why we need it:

This PR fixes the annotation key in the service to reconcile the network policies that allow scraping extension metrics in the seed. See: network_policies.md#seed-system-namespaces

Special notes for your reviewer:

/cc @rickardsjp @istvanballok @chrkl

Release note:

Fix the service annotation to reconcile the network policies that allow scraping extension metrics in the seed

vicwicker and others added 2 commits February 17, 2025 09:44
@vicwicker @rickardsjp
Fix network annotations to allow scraping in the seed
14cb4d1 
The old annotation did not have any effect in the network policy
reconciler.

Co-authored-by: Jeremy Rickards <[email protected]>
@vicwicker @rickardsjp
Run make generate
b7cda7f 
Co-authored-by: Jeremy Rickards <[email protected]>
@vicwicker vicwicker requested a review from a team as a code owner February 17, 2025 15:12
@gardener-robot gardener-robot added needs/review Needs review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 17, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 17, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 17, 2025
vpnachev
vpnachev approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Feb 17, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 17, 2025
dimityrmirchev
dimityrmirchev approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@dimityrmirchev dimityrmirchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dimityrmirchev dimityrmirchev merged commit af8e9c4 into gardener:master Feb 18, 2025
9 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Feb 18, 2025
@vicwicker vicwicker deleted the fix-seed-prometheus-scrape branch February 18, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vpnachev vpnachev vpnachev approved these changes

@dimityrmirchev dimityrmirchev dimityrmirchev approved these changes

Assignees

No one assigned

Labels

needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/closed Issue is closed (either delivered or triaged)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vicwicker @vpnachev @dimityrmirchev @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot