Skip to content

Add generation for Extension example #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kon-angelo merged 2 commits into from
Sep 17, 2025
Merged

Add generation for Extension example #1154

kon-angelo merged 2 commits into from
Sep 17, 2025

Conversation

@timuthy
Copy link
Member

@timuthy timuthy commented Aug 26, 2025 •
edited
Loading

How to categorize this PR?

/area ops-productivity
/kind enhancement
/platform gcp

What this PR does / why we need it:
This PR adds the generation for an Extension example manifest, similar to example/controller-registration.yaml which will be replaced on the long run.

Release note:

An example `Extension` manifest for extension registration has been added. It can be found at [`example/extension.yaml`](https://github.com/gardener/gardener-extension-provider-gcp/blob/master/example/extension.yaml)

@timuthy timuthy requested a review from a team as a code owner August 26, 2025 16:28
@gardener-robot gardener-robot added area/ops-productivity Operator productivity related (how to improve operations) kind/enhancement Enhancement, improvement, extension platform/gcp Google cloud platform/infrastructure needs/review Needs review size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 26, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 26, 2025
hebelsan
hebelsan previously approved these changes Sep 1, 2025
View reviewed changes
Copy link
Contributor

@hebelsan hebelsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Sep 1, 2025
tobschli
tobschli requested changes Sep 11, 2025
View reviewed changes
Copy link
Member

@tobschli tobschli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like a small typo made it's way in here

@gardener-robot gardener-robot added needs/changes Needs (more) changes needs/review Needs review and removed needs/review Needs review reviewed/lgtm Has approval for merging labels Sep 11, 2025
tobschli
tobschli reviewed Sep 11, 2025
View reviewed changes
Copy link
Member

@tobschli tobschli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@timuthy timuthy requested a review from hebelsan September 15, 2025 08:22
@kon-angelo kon-angelo requested a review from tobschli September 17, 2025 10:00
kon-angelo
kon-angelo approved these changes Sep 17, 2025
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kon-angelo kon-angelo merged commit 842c6c6 into gardener:master Sep 17, 2025
25 checks passed
@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging status/closed Issue is closed (either delivered or triaged) and removed needs/changes Needs (more) changes labels Sep 17, 2025
@timuthy timuthy deleted the enh/extension-example branch September 17, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kon-angelo kon-angelo kon-angelo approved these changes

@tobschli tobschli tobschli approved these changes

@hebelsan hebelsan Awaiting requested review from hebelsan

Assignees

No one assigned

Labels

area/ops-productivity Operator productivity related (how to improve operations) kind/enhancement Enhancement, improvement, extension platform/gcp Google cloud platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/closed Issue is closed (either delivered or triaged)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@timuthy @hebelsan @kon-angelo @tobschli @gardener-robot-ci-1 @gardener-robot