increase node sync workers #1138
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
|
@kon-angelo Labels area/todo, kind/todo do not exist. |
gardener-robot
added
the
size/XS
gardener-robot-ci-3
added
the
reviewed/ok-to-test
Contributor
|
Isn't that something we might want to make configurable for the user? |
Contributor
Author
|
Yes possibly. Since this component resides on the control-plane I am not sure we have a good way to restrict noisy neighbour situations. Why wouldn't any shoot owner just configure this value to e.g. max integer ? Ideally we would autoscale component values based on the cluster size. Our values for the controllers workers are low across the board and we need to re-evaluate them. Otherwise as you suggest we can expose some things, but not without thinking broader effects. This PR is only solving the issue short-term |
gardener-robot
added
reviewed/lgtm
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area TODO
/kind TODO
/platform gcp
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: