Update the regex selector for the unused MCM RBAC resources #1137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/compliance
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area compliance
/kind cleanup
/kind bug
/platform gcp
What this PR does / why we need it:
With the following PR , a migration runnable has been added to clean up leftover
ClusterRolesthat are not used anymore.The obsolete
ClusterRolesin question can be named in the following format:extensions.gardener.cloud:provider-gcp:shoot--<namespace>--<shoot_name>:machine-controller-managerHowever, the runnable logic does not take into account that for older installations, the
ClusterRolecould be named with a singular dash separator:extensions.gardener.cloud:provider-gcp:shoot-<namespace>-<shoot_name>:machine-controller-managerThis PR adjusts the regex to accept both name variations.
Which issue(s) this PR fixes:
NONE
Special notes for your reviewer:
Release note: