Skip to content

Conversation

@kon-angelo
Copy link
Contributor

How to categorize this PR?

/area control-plane
/kind bugfix
/platform azure

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fix a bug that disabled subnet's default outbound access.

@kon-angelo kon-angelo requested a review from a team as a code owner September 12, 2025 12:12
@gardener-robot gardener-robot added the needs/review Needs review label Sep 12, 2025
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 12, 2025
@gardener-robot gardener-robot added area/control-plane Control plane related platform/azure Microsoft Azure platform/infrastructure labels Sep 12, 2025
@gardener-robot
Copy link

@kon-angelo Label kind/bugfix does not exist.

@gardener-robot gardener-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 12, 2025
@github-actions github-actions bot added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 12, 2025
hebelsan
hebelsan previously approved these changes Sep 12, 2025
Copy link
Contributor

@hebelsan hebelsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Sep 12, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 12, 2025
@github-actions github-actions bot removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 12, 2025
@hebelsan hebelsan dismissed their stale review September 12, 2025 12:18

needs change

@gardener-robot gardener-robot added needs/review Needs review and removed reviewed/lgtm Has approval for merging labels Sep 12, 2025
@kon-angelo kon-angelo force-pushed the fix/default-outbound-annotation branch from fc09e6c to 214ae93 Compare September 12, 2025 13:16
@gardener-robot gardener-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 12, 2025
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 12, 2025
@github-actions
Copy link
Contributor

This change refactors and fixes how default outbound access for subnets is configured. It renames an internal field to better align with the Azure API and inverts the associated logic. More importantly, it corrects a bug where the configuration annotation was being read from the wrong resource. This ensures the disable-default-outbound-access shoot annotation is correctly applied, allowing users to control this networking behavior as intended.

Walkthrough

  • Bug Fix: Corrected the handling of the disable-default-outbound-access annotation. The controller now properly reads this annotation from the Shoot specification, allowing users to successfully disable default outbound internet access for newly created subnets.
  • Refactor: Renamed internal fields and functions related to subnet outbound access to improve code clarity and align more closely with the underlying Azure API's DefaultOutboundAccess property.

Model: gemini-2.5-pro | Prompt Tokens: 961 | Completion Tokens: 174

@github-actions github-actions bot removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 12, 2025
Copy link
Contributor

@hebelsan hebelsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Sep 12, 2025
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 12, 2025
@github-actions github-actions bot removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 12, 2025
@kon-angelo kon-angelo merged commit 3be4243 into gardener:master Sep 12, 2025
96 of 97 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/control-plane Control plane related needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/azure Microsoft Azure platform/infrastructure reviewed/lgtm Has approval for merging size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/closed Issue is closed (either delivered or triaged)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants