Skip to content

Conversation

@AleksandarSavchev
Copy link
Member

How to categorize this PR?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #624

Special notes for your reviewer:

Release note:

A bug causing Rule 1001 from Security Hardened Shoot Cluster guide to panic when target `NamespacedCloudProfile` has `.spec.kubernetes` field equal to `nil` was fixed.

@AleksandarSavchev AleksandarSavchev requested a review from a team as a code owner October 22, 2025 15:05
@gardener-prow gardener-prow bot added the kind/bug Bug label Oct 22, 2025
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 22, 2025
Copy link
Member

@dimityrmirchev dimityrmirchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2025
@gardener-prow
Copy link

gardener-prow bot commented Oct 23, 2025

LGTM label has been added.

DetailsGit tree hash: dca1653cd4d93cd28ea43ce37f6d3e49e4ad9d08

@gardener-prow
Copy link

gardener-prow bot commented Oct 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dimityrmirchev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2025
@gardener-prow gardener-prow bot merged commit 459a778 into gardener:main Oct 23, 2025
24 checks passed
@AleksandarSavchev
Copy link
Member Author

/cherry-pick release-v0.21.0

@gardener-ci-robot
Copy link
Collaborator

@AleksandarSavchev: new pull request created: #628

Details

In response to this:

/cherry-pick release-v0.21.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/bug Bug lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rule 1001 for security-hardened-shoot-cluster Panics with nil pointer refference

3 participants