Skip to content

Disable CGO on diki build workflow #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AleksandarSavchev merged 1 commit into from
Aug 27, 2025
Merged

Disable CGO on diki build workflow #573

AleksandarSavchev merged 1 commit into from
Aug 27, 2025

Conversation

@AleksandarSavchev
Copy link
Member

@AleksandarSavchev AleksandarSavchev commented Aug 27, 2025 •
edited by dimityrmirchev
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Use `ubuntu-24.04-arm` runner for diki executables builds in workflows.

Disable CGO for diki executables builds in workflows. This was causing the diki binaries to error in containers using alpine images.

@AleksandarSavchev AleksandarSavchev requested a review from a team as a code owner August 27, 2025 12:36
@gardener-robot gardener-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 27, 2025
dimityrmirchev
dimityrmirchev approved these changes Aug 27, 2025
View reviewed changes
Copy link
Member

@dimityrmirchev dimityrmirchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@AleksandarSavchev AleksandarSavchev merged commit 8562121 into gardener:main Aug 27, 2025
23 checks passed
AleksandarSavchev added a commit to AleksandarSavchev/diki that referenced this pull request Aug 27, 2025
@AleksandarSavchev
Disable CGO on go build (gardener#573)
2e21fb0 
(cherry picked from commit 8562121)
AleksandarSavchev added a commit that referenced this pull request Aug 27, 2025
@AleksandarSavchev
Disable CGO on go build (#573) (#574)
cff9591 
(cherry picked from commit 8562121)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dimityrmirchev dimityrmirchev dimityrmirchev approved these changes

Assignees

No one assigned

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AleksandarSavchev @dimityrmirchev @gardener-robot-ci-1 @gardener-robot