Add typescript note to README #478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's very helpful addition! |
calesce
requested changes
Feb 11, 2017
docs/README.md
Outdated
| @@ -28,6 +28,16 @@ | |||
| } | |||
| ``` | |||
|
|
|||
| - When using **typescript**, babel is not required, so your config should look like ([demo](https://github.com/Glavin001/react-hot-ts)): | |||
There was a problem hiding this comment.
Can you move this section to the bottom with its own header? Also, please capitalize TypeScript/Babel.
|
Looks great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was suggested we add a typescript note in #276.
At the moment all the examples in the readme include babel, which you don't use with typescript.
I've put this in the migration to 3.0 section straight after the babel config as I think it fits there. Can't think up enough to say to give typescript its own section.
Hopefully this helps anyone using typescript who runs in to the readme,