Skip to content

FS-1093-additional-conversions warning numbers have changed #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2022
Merged

FS-1093-additional-conversions warning numbers have changed #686

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions FSharp-6.0/FS-1093-additional-conversions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,12 +288,12 @@ As a result, four warnings are added, three of which are off by default:

2. FS3389: Type-directed conversion by a built-in numeric conversion (`int --> int64` etc.). This warning is OFF by default.

3. FS3390: Type-directed conversion by an `op_Implicit` conversion at method-argument position.
3. FS3395: Type-directed conversion by an `op_Implicit` conversion at method-argument position.
This warning is OFF by default.

4. FS3391: Type-directed conversion by an `op_Implicit` conversion at non-method-argument. This warning is ON by default.

The user can enable all these warnings through `--warnon:3386 --warnon:3387 --warnon:3388`. The warnings will contain a link to further documentation.
The user can enable all these warnings through `--warnon:3388 --warnon:3389 --warnon:3395`. The warnings will contain a link to further documentation.

This policy is chosen because `op_Implicit` is part of .NET library design, but in F# we generally only
want it applied at method argument position, like other adhoc conversions applied at that point.
Expand Down