[advancedcontentfilter] Fix Hook-call during install

[nupplaphil]

Fixes friendica/friendica#7989

Types of hook-calls:

• Hook::register() just registers hooks, but doesn't add them to the current call
• Hook::add() just adds hook to the current call, but doesn't register them

Since we want to call the db-definition hook just once during the install process, I switched from Hook::register() to Hook:add() and therefore removed the unregister call as well.

[MrPetovan]

I think this change is wrong. If the hook isn’t registered, the next time the DB update routine is called, the addon table won’t be added to the definition.

I’d rather the issue be fixed by calling Hook::add to Hook::register instead.

[nupplaphil]

I think tis change is wrong. If the hook isn’t registered, the next time the DB update routine is called, the addon table won’t be added to the definition.

But why do we need it here? The DB-upate routine is called directly here:

friendica-addons/advancedcontentfilter/advancedcontentfilter.php

Line 63 in 838c28f

DBStructure::update($a->getBasePath(), false, true);

And we don't need it at other places, so why should we store this hook?

I’d rather the issue be fixed by calling Hook::add to Hook::register instead.

This was my first thought, but than I found this description:
https://github.com/friendica/friendica/blob/cc64471e4c4cbda6f79c50ca784d0b927a45a6a5/src/Core/Hook.php#L67

My interpretation is that it is intentionally not added here. And I don't know what side-effects could cause it to other hooks. So I thought better stay at one point where only one addon could get broken instead of brick the whole hook-mechanism ;-)

[MrPetovan]

And we don't need it at other places, so why should we store this hook?

Imagine if we decide to delete tables absent from the definition? The addon table would be wiped out the next time the DB update routine is called.

A middle of the road approach would be to keep the register call and just add the add call.

[nupplaphil]

And we don't need it at other places, so why should we store this hook?

Imagine if we decide to delete tables absent from the definition? The addon table would be wiped out the next time the DB update routine is called.

A middle of the road approach would be to keep the register call and just add the add call.

Fair enough