Update unicode_smilies.php #1257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
:p in re:pubica was interpreted as emoji and output in text
tobiasd
reviewed
Jun 8, 2022
unicode_smilies/unicode_smilies.php
Outdated
There was a problem hiding this comment.
While it is correct that the emoticon names are enclosed by a pair of : at the beginning and the end, I don't think the same should be done with plain ASCII emoticons.
I think the problem with the :p you mentioned is rather, that two letter representations of the emoticons should not be replaced at all as their combination is to common in the normally used language.
There was a problem hiding this comment.
changed: The plain ASCII emoticons are not enclosed by a :
The plain ASCII emoticons are not enclosed by a :
MrPetovan
requested changes
Jun 8, 2022
unicode_smilies/unicode_smilies.php
Outdated
Comment on lines
234
to
235
There was a problem hiding this comment.
This doesn't look right either, both of these are meant to represent the actual smiley. Please either remove the trailing colon or disable the replacement altogether.
changed
MrPetovan
approved these changes
Jun 8, 2022
|
Thank you for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:p in re:pubica was interpreted as emoji and output in text