Add S3 Storage Backend #1236
Merged
Add S3 Storage Backend #1236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrPetovan
requested changes
Feb 25, 2022
MrPetovan
approved these changes
Feb 25, 2022
|
|
||
| Akeeba Amazon S3 Connector version 2 has dropped support for PPH 5.3 to 7.0 inclusive. It is only compatible with PHP 7.1 or later, up to and including PHP 8.0. | ||
|
|
||
| The most significant change in this version is that all methods use scalar type hints for parameters and return values. This _may_ break existing consumers which relied on implicit type conversion e.g. passing strings containing integer values instead of _actual_ integer values. |
There was a problem hiding this comment.
Good news for these consumers, scalar type hints also do implicit conversion from strings to integers!
Comment on lines
+12
to
+13
| // Protection against direct access | ||
| defined('AKEEBAENGINE') or die(); |
There was a problem hiding this comment.
Huh? What's the point of this in all the files?
|
I'll check this out with my test node mordor.social and a Minio server. Thank you! |
I think you have to use v2/legacy flag, afaik |
MrPetovan
reviewed
Feb 26, 2022
Comment on lines
+217
to
+221
| } else { | ||
| if (empty($this->getRegion())) { | ||
| $this->setRegion('us-east-1'); | ||
| } | ||
| } |
There was a problem hiding this comment.
Why not
} elseif (empty($this->getRegion())) {
$this->setRegion('us-east-1');
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's working :-)
I needed to fix the akeeba library as well (will create a PR for them), but at least I didn't have to include the official AWS library, which contains more than 8.300 files! I thought that would be insane for our specific use case.
I tested the S3 Backend with a Amazon S3 bucket and it worked well
I'd say it's ready :-)
btw. the tests will get fixed after #1238