Add interior mutability to CounterMarker #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using a safe Cell<u32> inside CounterMarker, we avoid having to put it inside an UnsafeCell and unsafely access it via a raw pointer.
Owner
|
Thank you for the contribution! Merging. |
Merged
frengor
added a commit
that referenced
this pull request
Apr 14, 2023
* Update to 0.1.1 * Fix the pessimistic quadratic behaviour of the Lins algorithm * [Add interior mutability to CounterMarker](#12) by @LegionMammal978 * Use [Iai](https://github.com/bheisler/iai) for running benchmarks on CI * Implement `Iterator` for `List` * Rename `all-non-nightly` feature to `full` * Put costly debug assertions behind the new `pedantic-debug-assertions` feature * Minor improvements and optimizations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using a safe
Cell<u32>insideCounterMarker, we avoid having to put it inside anUnsafeCelland unsafely access it via a raw pointer. This makesCounterMarker!Sync, but that doesn't break anything, sinceCcOnHeap<T>is already!Sync.