-
-
Notifications
You must be signed in to change notification settings - Fork 52
Translations update from Hosted Weblate #995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughAdded and updated localization JSON files for the Spook custom component: populated Lithuanian translations, refined a French typographic string, extended Italian entity translations, and added an empty Belarusian placeholder. No code or control-flow changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (2)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
custom_components/spook/translations/lt.json
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: HACS Validation
- GitHub Check: Pylint
🔇 Additional comments (3)
custom_components/spook/translations/lt.json (3)
1-52
: Translation entries forentity.sensor
look comprehensive and valid.
JSON syntax is correct and all keys are properly quoted. Great coverage for various sensor types.
53-57
: Switch translation is accurate.
Thecloud_alexa_report_state
key is translated appropriately.
59-69
: Issues fix flow structure is properly defined.
JSON structure for theissues
section is valid and matches the expected schema.
"fix_flow": { | ||
"step": { | ||
"confirm": { | ||
"description": "{Aprašymas}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Placeholder key should not be translated.
The placeholder {Aprašymas}
needs to match the original placeholder key (e.g., {description}
) to ensure that runtime substitution works. It should remain {description}
rather than translating the word.
Apply this diff:
- "description": "{Aprašymas}"
+ "description": "{description}"
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
"description": "{Aprašymas}" | |
"description": "{description}" |
🤖 Prompt for AI Agents
In custom_components/spook/translations/lt.json at line 64, the placeholder key
"{Aprašymas}" is incorrectly translated. Replace it with the original
placeholder key "{description}" to ensure proper runtime substitution and avoid
breaking the placeholder functionality.
51031de
to
d43ff8d
Compare
d43ff8d
to
fb60909
Compare
Currently translated at 15.3% (18 of 117 strings) Translation: Spook/Integration Translate-URL: https://hosted.weblate.org/projects/spook/integration/lt/
Currently translated at 100.0% (117 of 117 strings) Translation: Spook/Integration Translate-URL: https://hosted.weblate.org/projects/spook/integration/fr/
Currently translated at 43.5% (51 of 117 strings) Translation: Spook/Integration Translate-URL: https://hosted.weblate.org/projects/spook/integration/it/
fb60909
to
2ee95d4
Compare
|
Translations update from Hosted Weblate for Spook/Integration.
Current translation status: