hasParent method#407
Merged
seancorfield merged 2 commits intoframework-one:developfrom Dec 1, 2015
Ronner:master
Merged
Conversation
added 2 commits
December 1, 2015 12:41
…on of all beans if you don't provide the method with a beanname, eventhough the name of the method doesn't suggest that as it is a singular name.
Member
|
👍 Sorry it took a while to get there. For future submissions, please try to follow the FW/1 "house style" of whitespace in function call argument lists (since I'm kind of OCD about that). |
Member
|
Here's the tweaks I just made for "house style": b77fddd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My apologies Sean.. I wasn't aware yet that pull requests should only be done against the develop branch.