Skip to content
This repository was archived by the owner on Apr 30, 2018. It is now read-only.

feat(formlyConfigProvider): Expose field types map from formlyConfigProvider #669

Merged
merged 1 commit into from
Mar 21, 2016
Merged

feat(formlyConfigProvider): Expose field types map from formlyConfigProvider #669

merged 1 commit into from
Mar 21, 2016

Conversation

pcardune
Copy link
Contributor

What

Adding a getTypes() method to formlyConfigProvider that returns the map of type to config.

Why

For a plugin I am writing that renders an inspector showing the current configuration for formly, I
need access to the types that have been registered with formly.

How

This change exposes the map of type name to type configuration object via a new method on formlyConfigProvider called getTypes().

For issue #663

Checklist:

…rovider

For a plugin I am writing that renders an inspector showing the current configuration for formly, I
need access to the types that have been registered with formly. This change exposes the map of type
name to type configuration object via a new method on formlyConfigProvider called getTypes().

This is in support of issue #663
@codecov-io
Copy link

Current coverage is 95.87%

Merging #669 into master will increase coverage by +0.01% as of 2619e33

@@            master    #669   diff @@
======================================
  Files           16      16       
  Stmts         1161    1163     +2
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit           1113    1115     +2
  Partial          0       0       
  Missed          48      48       

Review entire Coverage Diff as of 2619e33


Uncovered Suggestions

  1. +0.34% via ...alidationMessages.js#25...28
  2. +0.26% via src/test.utils.js#38...40
  3. +0.26% via ...s/formlyUsability.js#18...20
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@kentcdodds
Copy link
Member

This looks just fine 👍

@kentcdodds
Copy link
Member

I'd still like someone else who actually uses the library still to review and merge this though.

@kwypchlo
Copy link
Member

LGTM if you have use case for it

kwypchlo added a commit that referenced this pull request Mar 21, 2016
feat(formlyConfigProvider): Expose field types map from formlyConfigProvider
@kwypchlo kwypchlo merged commit 21e96f1 into formly-js:master Mar 21, 2016
@kwypchlo
Copy link
Member

@pcardune could you provide some short docs on your feature here? http://docs.angular-formly.com/docs/formlyconfig (use suggest edit button in top right corner).

Are you still maintaining these docs @kentcdodds? I should write some docs to the stuffed I pushed too I guess...

@kentcdodds
Copy link
Member

I am, but would love to give some other people access.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants