Allow options on servers.all - as per the 'fog standard' #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: All other fog 'Servers' object allow you to pass an argument to `all`. The fact this one doesn't, means writing generic code for fog providers that relies on `.all(opts)` isn't possible. Solution: fog's goal is to facilitate generic code for multiple compute resources, so I suggest this method takes the same number of arguments as the rest.
|
👍 |
|
@geemus is there a mantainer for this fog plugin? |
|
/cc @fog/fog-azure <- I think that should ping everyone that I know of who it could fall to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
All other fog 'Servers' object allow you to pass an argument to
all. The fact this one doesn't, means writing generic code for fog providers that relies on.all(opts)isn't possible.Solution:
fog's goal is to facilitate generic code for multiple compute resources, so I suggest this method takes the same number of arguments as the rest.