Add post-render strategy support and conditional defaults - #1470
Conversation
matheuscscp
left a comment
There was a problem hiding this comment.
Just a nit, otherwise LGTM! 🚀
51c8f92 to
7944efd
Compare
|
@vocarista Sorry, I forgot something very important, please add the field docs to |
7944efd to
be6543d
Compare
|
Then please squash the commits into one and force-push 🙏 |
56c06b6 to
697a947
Compare
|
Squashed 👾 |
|
@vocarista Can you please open a PR here too? https://github.com/fluxcd/website/blob/main/content/en/flux/components/helm/options.md?plain=1#L67 Then a second PR here (highlighting the breaking change): They have to be two separate PRs because the second one will go live immediately |
|
@matheuscscp I've opened the PRs on fluxcd/website |
Signed-off-by: Kumar Piyush <kr.piyush888@gmail.com> Assisted By: Cascade/SWE-1.6:
2b42312 to
8f1b711
Compare
matheuscscp
left a comment
There was a problem hiding this comment.
LGTM! 🚀
@vocarista Thanks very much!
Fixes #1469
combined(Helm 4 breaking change), then in Flux 2.8.6 we fixed the regression (changed the behavior tonohooks). In Flux 2.9 (through this PR) we are changing this default back tocombinedfor honoring the feature gateUseHelm3Defaults, which defaults to the Helm 4 defaults when the gate isfalse, and to the Helm 3 defaults when the gate istrue. We are sustaining our decision to keep aligned with Helm's defaults throughout Flux's and Helm's lives. This commitment implies shipping breaking changes whenever Helm changes default functionality in major versions.The behavior can also be pinned to a specific value directly in the
HelmReleaseobject through the field introduced in this PR.Adds support for Helm's post-render strategies (nohooks, combined, separate) being introduced in Helm 4.2. The new
spec.postRenderStrategyfield allows users to configure how hooks are sent to post-renderers.Changes:
PostRenderStrategyenum with values:nohooks,combined,separatespec.postRenderStrategyfield toHelmReleaseSpectoHelmPostRenderStrategy()mapping function in action packageDefault behavior:
combinedto align with upstream HelmUseHelm3Defaultsfeature gate by switching tonohookswhen enabled