Skip to content

Add Drifted condition to HelmRelease - #1367

Merged
stefanprodan merged 1 commit into
fluxcd:mainfrom
yozel:yozel/add-drifted-condition
Mar 10, 2026
Merged

Add Drifted condition to HelmRelease#1367
stefanprodan merged 1 commit into
fluxcd:mainfrom
yozel:yozel/add-drifted-condition

Conversation

@yozel

@yozel yozel commented Dec 4, 2025

Copy link
Copy Markdown
Contributor

This PR Introduces a new condition type "Drifted" to improve observability of Helm release drift detection.

Fix: #1241

@yozel yozel changed the title Add Drifted condition Add Drifted condition to HelmRelease and log generation Dec 4, 2025
@yozel yozel changed the title Add Drifted condition to HelmRelease and log generation Add Drifted condition to HelmRelease Dec 24, 2025
Comment thread internal/reconcile/atomic_release.go Outdated
Comment thread internal/reconcile/atomic_release.go Outdated
@matheuscscp

Copy link
Copy Markdown
Member

It would be nice to add a test for when the condition is false

@yozel

yozel commented Jan 8, 2026

Copy link
Copy Markdown
Contributor Author

It would be nice to add a test for when the condition is false

I'll add it right now

@matheuscscp matheuscscp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Comment thread internal/reconcile/atomic_release.go
@yozel

yozel commented Feb 24, 2026

Copy link
Copy Markdown
Contributor Author

Hi, I've rebased the branch with the latest main. Do you think this PR is ready for merge, or is there any work needs to be done before that?

This commit introduces a new Kubernetes condition type "Drifted" to
improve observability of Helm release drift detection.

Signed-off-by: Yasin Özel <yozel@nebius.com>

@stefanprodan stefanprodan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @yozel 🏅

@stefanprodan stefanprodan added enhancement New feature or request area/drift Drift detection/correction related issues and pull requests labels Mar 10, 2026
@stefanprodan
stefanprodan merged commit 0e8bf5f into fluxcd:main Mar 10, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/drift Drift detection/correction related issues and pull requests enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drift detection in warn mode - having status field or metrics to have alerting

3 participants