Added webview scrolling listener #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix #125 |
lejard-h
requested changes
Jul 26, 2018
lib/src/base.dart
Outdated
| @@ -60,6 +64,8 @@ class FlutterWebviewPlugin { | |||
| /// more detail than other events | |||
| Stream<WebViewStateChanged> get onStateChanged => _onStateChanged.stream; | |||
|
|
|||
|
|
|||
| Stream<String> get onScrollChanged => _onScrollChanged.stream; | |||
There was a problem hiding this comment.
please comments dart API. what is the String value ? could we pass an other object ? yPos, xPos ... ?
There was a problem hiding this comment.
Currently the streaming value is only "UP" or "DOWN". I can try to change it to stream two integer value tonight
There was a problem hiding this comment.
no possibility to scroll horizontally ?
# Conflicts: # android/src/main/java/com/flutter_webview_plugin/WebviewManager.java # example/lib/main.dart # lib/src/base.dart
|
@lejard-h I have made some changes to the API, there's now two stream event each listen to the horizontal scroll ( onScrollYChanged ) and vertical scroll ( onScrollXChanged ). You can reference the readme for more details |
charafau
pushed a commit
that referenced
this pull request
Apr 7, 2020
Added webview scrolling listener
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a webview scroll listener, example:
webviewReference.onScrollChanged.listen((String scrollDirection) {
print(scrollDirection);
});