-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add initial preview and review cards to FWE #12821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @parlough, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the tutorial experience by adding 'SummaryCard' components to various lesson pages. These cards serve as quick reference points, outlining the learning objectives at the beginning and summarizing the key takeaways at the end of each tutorial. This change aims to improve content clarity and navigation for users engaging with the learning material. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces SummaryCard components at the beginning and end of numerous tutorial pages, which is a great enhancement for learners. The changes also include the necessary styling for these new cards. My review provides a few suggestions to refine the SCSS and correct minor issues in the markdown content.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
Visit the preview URL for this PR (updated for commit 10b686f): https://flutter-docs-prod--pr12821-feat-fwe-preview-review-tila5t2w.web.app |
sfshaza2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this looks good, but I am wondering about the icons in "what you'll learn" and the summary, such as you see here: https://flutter-docs-prod--pr12821-feat-fwe-preview-review-tila5t2w.web.app/learn/tutorial/change-notifier.
I'm not sure that I learn much from the icons. Is there an icon glossary somewhere?
|
+1 to Shams comment... We should be intentional about the icons. If there aren't suitable icons then we can maybe have someone create them. tbh these look pretty good to me. I'd prefer to just land them and edit them holistically when I do a final pass |
@ericwindmill These are rather rough, so please do either modify these now or as a follow-up to match your vision for each lesson.