This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[webview_flutter] Re-land support v2 embedding support #2209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 17, 2019 10:25
This reverts commit 2ca7b52.
This correctly sets the minimum SDK to the latest stable and avoid any compile errors. *WARNING:* the V2 embedding itself still requires the current Flutter master channel (flutter/flutter@1d4d63a) for text input to work properly on all Android versions.
xster
reviewed
Oct 31, 2019
| .getPlatformViewsController() | ||
| .getRegistry() | ||
| .registerViewFactory( | ||
| "plugins.flutter.io/webview", new WebViewFactory(messenger, /*containerView=*/ null)); |
There was a problem hiding this comment.
It's a subjective style decision. I tend to manually write in parameter hints in the style of /*parameterName=*/ to make function calls easier to reason about even when the code is being read as plain text.
// Extreme hypothetical confusing example.
return new Fraction(/*numerator=*/2, /*denominator=*/3);Most IDEs will automatically do this for you, but for reading Github or something like Vim I think it's helpful.
This can have negative side affects for apps and isn't needed.
mormih
pushed a commit
to mormih/plugins
that referenced
this pull request
Nov 17, 2019
sungmin-park
pushed a commit
to sungmin-park/flutter-plugins
that referenced
this pull request
Dec 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This correctly sets the minimum SDK to the latest stable and avoid any
compile errors. WARNING: the V2 embedding itself still requires the
current Flutter master channel (flutter/flutter@1d4d63a) for text input
to work properly on all Android versions.
Related Issues
Fixes flutter/flutter#41851.
Related to flutter/flutter#42860.
Related to flutter/flutter#42792.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?