-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[camera_avfoundation] Implementation swift migration - part 12 #9781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[camera_avfoundation] Implementation swift migration - part 12 #9781
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request continues the migration of the camera_avfoundation
plugin to Swift by moving the FLTCam
initialization logic into the Swift DefaultCamera
class. This includes moving many properties from the Objective-C superclass to the Swift subclass, improving encapsulation. The changes are well-structured and the updates to tests and other parts of the codebase are consistent with the migration.
My review includes a few suggestions to improve maintainability and fix a potential issue in the new DefaultCamera
initializer related to error handling and testability.
.../camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/DefaultCamera.swift
Outdated
Show resolved
Hide resolved
.../camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/DefaultCamera.swift
Outdated
Show resolved
Hide resolved
.../camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/DefaultCamera.swift
Outdated
Show resolved
Hide resolved
.../camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/DefaultCamera.swift
Outdated
Show resolved
Hide resolved
From triage: is this waiting on anything to be landed? |
I'm on vacation ATM. I will land this once I'm back on Friday |
7d7fe6d
to
5532f6f
Compare
Migrates camera implementation as part of flutter/flutter#119109
This PR migrates the 9th chunk of
FLTCam
class to Swift:init
FLTCam
toDefaultCamera
textureId
field fromFLTCam
(it seemscameraId
is used as "texture id" and this field wasn't used for a while now)Some properties of the FLTCam have to be temporarily made public so that they are accessible in DefaultCamera.
Pre-Review Checklist
[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assist
bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3