[google_maps_flutter] Remove legacy renderer tests #9517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the copy of the integration tests that attempted to run against the legacy renderer, as the legacy renderer is no longer available. The tests are now just duplicating integration tests (the slowest and flakiest tests, generally), and the test that asserts that it's testing the legacy renderer is now failing, closing the tree. Also removes the README discussion of the renderer option, since it's no longer useful to clients. Will fix the tree closure. Part of flutter/flutter#171338
reidbaker
reviewed
Jun 30, 2025
| @@ -1,3 +1,8 @@ | |||
| ## 0.6.19 | |||
There was a problem hiding this comment.
I dont think you want this in your pr.
There was a problem hiding this comment.
Are you looking at the commit where I merged in main rather than the full PR?
reidbaker
requested changes
Jun 30, 2025
There was a problem hiding this comment.
@stuartmorgan-g this appears to be a camera and video player pr but the description sounds like google maps? I am confused.
The PR only changes |
reidbaker
reviewed
Jun 30, 2025
reidbaker
approved these changes
Jun 30, 2025
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 30, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 30, 2025
flutter/packages@4841ada...471bfd3 2025-06-30 [email protected] [google_maps_flutter] Remove legacy renderer tests (flutter/packages#9517) 2025-06-30 49699333+dependabot[bot]@users.noreply.github.com Bump lewagon/wait-on-check-action from 1.3.4 to 1.4.0 in the all-github-actions group (flutter/packages#9524) 2025-06-29 [email protected] [camera_android_camerax] Fix incorrectly rotated captured photos (flutter/packages#9498) 2025-06-29 [email protected] [in_app_purchase] Annotate deprecation in test (flutter/packages#9473) 2025-06-29 [email protected] [video_player] Add poster attribute for html video tag in video_player_platform_interface (flutter/packages#8979) 2025-06-29 [email protected] Roll Flutter (stable) from 6fba244 to fcf2c11 (6 revisions) (flutter/packages#9502) 2025-06-29 [email protected] Skip test to unblock packages (flutter/packages#9516) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Jul 21, 2025
…r#171384) flutter/packages@4841ada...471bfd3 2025-06-30 [email protected] [google_maps_flutter] Remove legacy renderer tests (flutter/packages#9517) 2025-06-30 49699333+dependabot[bot]@users.noreply.github.com Bump lewagon/wait-on-check-action from 1.3.4 to 1.4.0 in the all-github-actions group (flutter/packages#9524) 2025-06-29 [email protected] [camera_android_camerax] Fix incorrectly rotated captured photos (flutter/packages#9498) 2025-06-29 [email protected] [in_app_purchase] Annotate deprecation in test (flutter/packages#9473) 2025-06-29 [email protected] [video_player] Add poster attribute for html video tag in video_player_platform_interface (flutter/packages#8979) 2025-06-29 [email protected] Roll Flutter (stable) from 6fba244 to fcf2c11 (6 revisions) (flutter/packages#9502) 2025-06-29 [email protected] Skip test to unblock packages (flutter/packages#9516) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth
pushed a commit
to vashworth/packages
that referenced
this pull request
Jul 30, 2025
Removes the copy of the integration tests that attempted to run against the legacy renderer, as the legacy renderer is no longer available. The tests are now just duplicating integration tests (the slowest and flakiest tests, generally), and the test that asserts that it's testing the legacy renderer is now failing (requiring a recent change to skip it). Since we no longer need to run the same set of tests in two different modes, I combined `latest_renderer_tests.dart` into `google_maps_test.dart` (renamed so it's picked up as an integration test entry point). Also removes the README discussion of the renderer option, since it's no longer useful to clients. Part of flutter/flutter#171338 Fixes flutter/flutter#171306 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the copy of the integration tests that attempted to run against the legacy renderer, as the legacy renderer is no longer available. The tests are now just duplicating integration tests (the slowest and flakiest tests, generally), and the test that asserts that it's testing the legacy renderer is now failing (requiring a recent change to skip it).
Since we no longer need to run the same set of tests in two different modes, I combined
latest_renderer_tests.dartintogoogle_maps_test.dart(renamed so it's picked up as an integration test entry point).Also removes the README discussion of the renderer option, since it's no longer useful to clients.
Part of flutter/flutter#171338
Fixes flutter/flutter#171306
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3