Skip to content

Conversation

Phantom-101
Copy link

Use RadioGroup to avoid deprecated groupValue and onChanged (flutter/flutter#170915)

Pre-Review Checklist

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@stuartmorgan-g
Copy link
Collaborator

Thanks for the contribution! Marking as a draft for now since this will require min SDK updates, and that can't be done in the PR until the next stable has shipped.

@stuartmorgan-g stuartmorgan-g removed the waiting for stable update Can't be landed until functionality reaches the stable channel label Aug 19, 2025
@stuartmorgan-g
Copy link
Collaborator

It should be possible to update this to be landable now that 3.35 has shipped to stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants