[in_app_purchase_android] GooglePlayPurchaseParam add possibility set selected offerToken #8452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmackall
reviewed
Mar 11, 2025
There was a problem hiding this comment.
This completely fell off my review queue, I'm sorry for the delay here.
This mostly LGTM, but before we can land can you
- resolve the conflicts
- Fix the format failure (you can see this either from the logs of the failing
Linux repo_checkscheck (link1 -> link2) or by following the formatting readme (basically justdart formatthe dart code here). - Update the CHANGELOG to follow the style guide https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style (maybe something like "Adds support for setting the
offerTokenonGooglePlayPurchaseParam.)
gmackall
reviewed
Mar 17, 2025
|
@rmasarovic Are you still working on this PR? I can take over making the changelog changes if not, let me know. |
|
@rmasarovic I've updated the PR according to my comments as it appeared you were no longer working on it, hopefully that is ok! Will get this reviewed by other team members, to avoid reviewing my own changes. |
bparrishMines
approved these changes
Jun 3, 2025
| }); | ||
|
|
||
| /// The 'changeSubscriptionParam' containing information for upgrading or | ||
| /// downgrading an existing subscription. | ||
| final ChangeSubscriptionParam? changeSubscriptionParam; | ||
|
|
||
| /// For One-time product, "offerToken" shouldn't be filled. |
There was a problem hiding this comment.
nit: Add a space after first sentence.
gmackall
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/packages/8452, because This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.
|
gmackall
approved these changes
Jun 3, 2025
gmackall
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 4, 2025
…bility set selected offerToken (flutter/packages#8452)
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 4, 2025
flutter/packages@1765c95...2bac766 2025-06-03 [email protected] [in_app_purchase_android] GooglePlayPurchaseParam add possibility set selected offerToken (flutter/packages#8452) 2025-06-03 [email protected] [camera] 🐛 Fix toggles overflow in the camera example (flutter/packages#9274) 2025-06-03 [email protected] [shared_preferences] Remove duplicate integration test (flutter/packages#9368) 2025-06-03 [email protected] [pointer_interceptor_web] Fix unresponsive input above PointerInterceptor on Safari and Firefox. (flutter/packages#9362) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ortes
pushed a commit
to Ortes/packages
that referenced
this pull request
Jun 25, 2025
… selected offerToken (flutter#8452) Option to add purchase parameters in GooglePlayPurchaseParam to set selected offer token. In subscribtion with multiple offer in base plan, the user can choose which offer to want buy and then this selected offer token is sent to the billing flow flutter/flutter#150348
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Option to add purchase parameters in GooglePlayPurchaseParam to set selected offer token. In subscribtion with multiple offer in base plan, the user can choose which offer to want buy and then this selected offer token is sent to the billing flow
flutter/flutter#150348
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.