[google_maps_flutter] Switch Android examples to TLHC #7282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Android example apps were still using HC mode, from when that was the recommended option due to lost updates with TLHC. Now that the README strongly recommends using TLHC rather than HC, we should reflect that in our examples. This is both a user-facing change, since it's what shows on pub.dev and we want to set the right example there, and also cahnges our test coverage. Ideally we would test both, and an issue will be filed to explore that, but for as long as we are only testing one it should be the recommended option.
|
This came up in the context of investigating flutter/flutter#152691, and I think it's just an oversight that we hadn't changed this. |
reidbaker
approved these changes
Aug 1, 2024
stuartmorgan-g
added
the
autosubmit
|
Landing in parallel with the last couple of in-progress post-submit tests to unblock starting a new trial roll to see if this unblocks things. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 2, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 2, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 2, 2024
flutter/packages@27896d1...cc9ff47 2024-08-02 [email protected] [tool] Add note about clang version used in CI to tool readme (flutter/packages#7273) 2024-08-02 [email protected] [ci] Re-enable google_maps_flutter_web integration tests. (flutter/packages#7269) 2024-08-01 [email protected] [web] Update package:web to ">=0.5.1 <2.0.0" (flutter/packages#7202) 2024-08-01 [email protected] [go_router] Documentation for StatefulShellRoute (flutter/packages#6308) 2024-08-01 [email protected] [google_maps_flutter] Switch Android examples to TLHC (flutter/packages#7282) 2024-08-01 [email protected] Manual roll Flutter from f817e51 to e2e4398 (5 revisions) (flutter/packages#7276) 2024-08-01 [email protected] [various] Clean up C++ formatting (flutter/packages#7272) 2024-08-01 [email protected] [shared_preferences] fix stringlist bug (flutter/packages#7268) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
flutter/packages@27896d1...cc9ff47 2024-08-02 [email protected] [tool] Add note about clang version used in CI to tool readme (flutter/packages#7273) 2024-08-02 [email protected] [ci] Re-enable google_maps_flutter_web integration tests. (flutter/packages#7269) 2024-08-01 [email protected] [web] Update package:web to ">=0.5.1 <2.0.0" (flutter/packages#7202) 2024-08-01 [email protected] [go_router] Documentation for StatefulShellRoute (flutter/packages#6308) 2024-08-01 [email protected] [google_maps_flutter] Switch Android examples to TLHC (flutter/packages#7282) 2024-08-01 [email protected] Manual roll Flutter from f817e51 to e2e4398 (5 revisions) (flutter/packages#7276) 2024-08-01 [email protected] [various] Clean up C++ formatting (flutter/packages#7272) 2024-08-01 [email protected] [shared_preferences] fix stringlist bug (flutter/packages#7268) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
flutter/packages@27896d1...cc9ff47 2024-08-02 [email protected] [tool] Add note about clang version used in CI to tool readme (flutter/packages#7273) 2024-08-02 [email protected] [ci] Re-enable google_maps_flutter_web integration tests. (flutter/packages#7269) 2024-08-01 [email protected] [web] Update package:web to ">=0.5.1 <2.0.0" (flutter/packages#7202) 2024-08-01 [email protected] [go_router] Documentation for StatefulShellRoute (flutter/packages#6308) 2024-08-01 [email protected] [google_maps_flutter] Switch Android examples to TLHC (flutter/packages#7282) 2024-08-01 [email protected] Manual roll Flutter from f817e51 to e2e4398 (5 revisions) (flutter/packages#7276) 2024-08-01 [email protected] [various] Clean up C++ formatting (flutter/packages#7272) 2024-08-01 [email protected] [shared_preferences] fix stringlist bug (flutter/packages#7268) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Android example apps were still using HC mode, from when that was the recommended option due to lost updates with TLHC. Now that the README strongly recommends using TLHC rather than HC, we should reflect that in our examples.
This is both a user-facing change, since it's what shows on pub.dev and we want to set the right example there, and also changes our test coverage. Ideally we would test both, and an issue will be filed to explore that, but for as long as we are only testing one it should be the recommended option.
This came up in the context of investigating flutter/flutter#152691 where impeller on google maps when using hybrid composition caused a crash, and I think it's just an oversight that we hadn't changed this.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).