[in_app_purchase_storekit] convert TranslatorTests to swift #7232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LouiseHsu
changed the title
| @@ -0,0 +1 @@ | |||
| ../../shared/RunnerTests/TranslatorTests.swift | |||
There was a problem hiding this comment.
the actual test file gets put in shared/RunnerTests and the ios/macos workspaces just symlink to it. i guess this is what the symlinks look like
| @@ -82,7 +82,7 @@ final class InAppPurchasePluginTests: XCTestCase { | |||
| } | |||
|
|
|||
| XCTAssertEqual(unwrappedProducts.count, 1) | |||
| XCTAssertEqual(response.invalidProductIdentifiers, nil) | |||
| XCTAssertEqual(response.invalidProductIdentifiers, []) | |||
There was a problem hiding this comment.
why this behavior change?
There was a problem hiding this comment.
obj-c let me pass in a nil with no objections, but invalidProductIdentifiers is not an optional field in swift version of the api https://developer.apple.com/documentation/storekit/skproductsresponse/1505985-invalidproductidentifiers
| @testable import in_app_purchase_storekit | ||
|
|
||
| final class ObjectTranslatorTest: XCTestCase { | ||
| var periodMap: [String: Any] { |
| let period = SKProductSubscriptionPeriodStub(map: periodMap) | ||
| let map = FIAObjectTranslator.getMapFrom(period) | ||
|
|
||
| XCTAssertEqual(map as NSDictionary, periodMap as NSDictionary) |
There was a problem hiding this comment.
Does this test pass? it should be XCTAssertEqualObjects
There was a problem hiding this comment.
oh nevermind, this is swift.
hellohuanlin
approved these changes
Jul 31, 2024
LouiseHsu
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 1, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 1, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 1, 2024
flutter/packages@46a712f...27896d1 2024-08-01 [email protected] [local_auth_darwin] macOS Support (flutter/packages#6267) 2024-08-01 [email protected] Manual roll Flutter from 4d12197 to f817e51 (7 revisions) (flutter/packages#7270) 2024-08-01 [email protected] [ci] version_check_command now checks markdown of first CHANGELOG line. (flutter/packages#7266) 2024-08-01 [email protected] Manual roll Flutter from 031dc3d to 4d12197 (12 revisions) (flutter/packages#7259) 2024-07-31 [email protected] [in_app_purchase_storekit] convert TranslatorTests to swift (flutter/packages#7232) 2024-07-31 [email protected] [google_maps_flutter_web] Migrate to `google_maps: 8.0.0` (flutter/packages#7077) 2024-07-31 [email protected] [tool] Run pre_publish.dart before publish --dry-run (flutter/packages#7258) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
flutter/packages@46a712f...27896d1 2024-08-01 [email protected] [local_auth_darwin] macOS Support (flutter/packages#6267) 2024-08-01 [email protected] Manual roll Flutter from 4d12197 to f817e51 (7 revisions) (flutter/packages#7270) 2024-08-01 [email protected] [ci] version_check_command now checks markdown of first CHANGELOG line. (flutter/packages#7266) 2024-08-01 [email protected] Manual roll Flutter from 031dc3d to 4d12197 (12 revisions) (flutter/packages#7259) 2024-07-31 [email protected] [in_app_purchase_storekit] convert TranslatorTests to swift (flutter/packages#7232) 2024-07-31 [email protected] [google_maps_flutter_web] Migrate to `google_maps: 8.0.0` (flutter/packages#7077) 2024-07-31 [email protected] [tool] Run pre_publish.dart before publish --dry-run (flutter/packages#7258) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
flutter/packages@46a712f...27896d1 2024-08-01 [email protected] [local_auth_darwin] macOS Support (flutter/packages#6267) 2024-08-01 [email protected] Manual roll Flutter from 4d12197 to f817e51 (7 revisions) (flutter/packages#7270) 2024-08-01 [email protected] [ci] version_check_command now checks markdown of first CHANGELOG line. (flutter/packages#7266) 2024-08-01 [email protected] Manual roll Flutter from 031dc3d to 4d12197 (12 revisions) (flutter/packages#7259) 2024-07-31 [email protected] [in_app_purchase_storekit] convert TranslatorTests to swift (flutter/packages#7232) 2024-07-31 [email protected] [google_maps_flutter_web] Migrate to `google_maps: 8.0.0` (flutter/packages#7077) 2024-07-31 [email protected] [tool] Run pre_publish.dart before publish --dry-run (flutter/packages#7258) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of flutter/flutter#151624
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes].///).