-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[xdg_directories] Add example app #4554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[xdg_directories] Add example app #4554
Conversation
@stuartmorgan the PR is ready for another review. Here's a new screenshot: Thanks for your comments. ![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks!
@gspencergoog Could you do the second review on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eriko13 It's not necessary to constantly re-merge |
@stuartmorgan Sorry! I thought I had to re-merge /main so the submit-queue check could refresh. Got it, I'll leave it as is. Thanks! |
flutter/packages@d7ee75a...ac41376 2023-08-08 [email protected] Roll Flutter from ad0aa8d to 436df69 (17 revisions) (flutter/packages#4663) 2023-08-08 [email protected] [webview_flutter_wkwebview] Repeatedly pump WebViews until one is garbage collected (flutter/packages#4662) 2023-08-08 [email protected] [xdg_directories] Add example app (flutter/packages#4554) 2023-08-08 [email protected] [pigeon] Recursively create output target files (flutter/packages#4458) 2023-08-07 [email protected] [path_provider] Add getApplicationCachePath() (flutter/packages#4483) 2023-08-07 [email protected] [flutter_markdown] Adopt code excerpts in README (flutter/packages#4656) 2023-08-07 [email protected] [All] Expand artifact hub to all plugins (flutter/packages#4645) 2023-08-07 [email protected] Roll Flutter from 2ba9f7b to ad0aa8d (31 revisions) (flutter/packages#4659) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Created a demo app for the xdg_directories package to showcase some of the basic functionalities.
Fixes: #128698
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.md
to add a description of the change, [following repository CHANGELOG style].///
).If you need help, consider asking for advice on the #hackers-new channel on [Discord].