Skip to content

[camerax] Add Kotlin duplicate classes known error to README.md #3957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 10, 2023
Merged

[camerax] Add Kotlin duplicate classes known error to README.md #3957

merged 9 commits into from
May 10, 2023

Conversation

camsim99
Copy link
Contributor

@camsim99 camsim99 commented May 10, 2023 •
edited
Loading

Adds warning about Kotlin duplicate class error to README.md.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@camsim99 camsim99 marked this pull request as ready for review May 10, 2023 17:23
stuartmorgan-g
stuartmorgan-g approved these changes May 10, 2023
View reviewed changes
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/camera/camera_android_camerax/CHANGELOG.md Outdated
@@ -1,3 +1,7 @@
## 0.5.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: 0.5.0+1

packages/camera/camera_android_camerax/README.md Outdated
@@ -49,6 +49,15 @@ Any specified `ResolutionPreset` wll go unused in favor of CameraX defaults and

`setZoomLevel` is unimplemented.

## Known Issue
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Known Issues

(Since we may have others in the future, and will probably forget to change it if we do.)

@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label May 10, 2023
@auto-submit auto-submit bot merged commit 90164b7 into flutter:main May 10, 2023
@reidbaker reidbaker mentioned this pull request May 12, 2023
Merged
11 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 15, 2023
@engine-flutter-autoroll
90164b7 [camerax] Add Kotlin duplicate classes known error to README.…
5c93d27 
…md (flutter/packages#3957)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 15, 2023
@engine-flutter-autoroll
90164b7 [camerax] Add Kotlin duplicate classes known error to README.…
676fdaf 
…md (flutter/packages#3957)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 15, 2023
@engine-flutter-autoroll
90164b7 [camerax] Add Kotlin duplicate classes known error to README.…
d01687a 
…md (flutter/packages#3957)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 15, 2023
@engine-flutter-autoroll
Roll Packages from 6328cfb to 6608b60 (22 revisions) (#126865)
96580f5 
flutter/packages@6328cfb...6608b60

2023-05-15 [email protected] [ci] Remove unnecessary Linux libraries (flutter/packages#3975)
2023-05-15 [email protected] [ci] Enforce a minimum Kotlin version in examples (flutter/packages#3979)
2023-05-15 [email protected] [ci] Disable Windows repo tool tests (flutter/packages#3980)
2023-05-12 [email protected] [ci] Add LUCI repo tool tests (flutter/packages#3964)
2023-05-12 [email protected] [url_launcher] Set broadcast reciever visability as required by target api 34 (flutter/packages#3973)
2023-05-12 [email protected] Update build.gradle with a comment explaining version (flutter/packages#3972)
2023-05-12 [email protected] Roll Flutter from 8c5a1ea to a76dbe4 (12 revisions) (flutter/packages#3958)
2023-05-12 [email protected] [image_picker] Fix Android lints (flutter/packages#3887)
2023-05-12 [email protected] [various] Update minimum Flutter version to 3.3 (flutter/packages#3967)
2023-05-12 [email protected] [tool] Target specific Android unit tests (flutter/packages#3955)
2023-05-12 [email protected] [camerax] Add a dependency on kotlin-bom to align versions of kotlin-stdlib (flutter/packages#3960)
2023-05-12 [email protected] [local_auth] Improve iOS test DI (flutter/packages#3959)
2023-05-12 [email protected] [ci] Ensure scripts fail if a command fails (flutter/packages#3963)
2023-05-11 [email protected] [ci] Pin the Flutter version for `release` (flutter/packages#3965)
2023-05-11 [email protected] [video_player] foundation - reduce seek accuracy to fix seek to end bug (flutter/packages#3784)
2023-05-11 [email protected] [image_picker] Fix use_build_context_synchronously violations (flutter/packages#3969)
2023-05-11 [email protected] [tool] Ensure that publish credential path is available (flutter/packages#3970)
2023-05-11 [email protected] [go_router] change `fix_data.yaml` uris to be absolute to fix lints (flutter/packages#3877)
2023-05-11 [email protected] [tool] Use new pub cache location for publish (flutter/packages#3962)
2023-05-10 [email protected] Roll Flutter (stable) from f72efea to 84a1e90 (1920 revisions) (flutter/packages#3961)
2023-05-10 [email protected] [image_picker_android] Improved Bitmap resize on Android (flutter/packages#3423)
2023-05-10 [email protected] [camerax] Add Kotlin duplicate classes known error to README.md (flutter/packages#3957)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@engine-flutter-autoroll
Roll Packages from 6328cfb to 6608b60 (22 revisions) (flutter#126865)
e39437c 
flutter/packages@6328cfb...6608b60

2023-05-15 [email protected] [ci] Remove unnecessary Linux libraries (flutter/packages#3975)
2023-05-15 [email protected] [ci] Enforce a minimum Kotlin version in examples (flutter/packages#3979)
2023-05-15 [email protected] [ci] Disable Windows repo tool tests (flutter/packages#3980)
2023-05-12 [email protected] [ci] Add LUCI repo tool tests (flutter/packages#3964)
2023-05-12 [email protected] [url_launcher] Set broadcast reciever visability as required by target api 34 (flutter/packages#3973)
2023-05-12 [email protected] Update build.gradle with a comment explaining version (flutter/packages#3972)
2023-05-12 [email protected] Roll Flutter from 8c5a1ea to a76dbe4 (12 revisions) (flutter/packages#3958)
2023-05-12 [email protected] [image_picker] Fix Android lints (flutter/packages#3887)
2023-05-12 [email protected] [various] Update minimum Flutter version to 3.3 (flutter/packages#3967)
2023-05-12 [email protected] [tool] Target specific Android unit tests (flutter/packages#3955)
2023-05-12 [email protected] [camerax] Add a dependency on kotlin-bom to align versions of kotlin-stdlib (flutter/packages#3960)
2023-05-12 [email protected] [local_auth] Improve iOS test DI (flutter/packages#3959)
2023-05-12 [email protected] [ci] Ensure scripts fail if a command fails (flutter/packages#3963)
2023-05-11 [email protected] [ci] Pin the Flutter version for `release` (flutter/packages#3965)
2023-05-11 [email protected] [video_player] foundation - reduce seek accuracy to fix seek to end bug (flutter/packages#3784)
2023-05-11 [email protected] [image_picker] Fix use_build_context_synchronously violations (flutter/packages#3969)
2023-05-11 [email protected] [tool] Ensure that publish credential path is available (flutter/packages#3970)
2023-05-11 [email protected] [go_router] change `fix_data.yaml` uris to be absolute to fix lints (flutter/packages#3877)
2023-05-11 [email protected] [tool] Use new pub cache location for publish (flutter/packages#3962)
2023-05-10 [email protected] Roll Flutter (stable) from f72efea to 84a1e90 (1920 revisions) (flutter/packages#3961)
2023-05-10 [email protected] [image_picker_android] Improved Bitmap resize on Android (flutter/packages#3423)
2023-05-10 [email protected] [camerax] Add Kotlin duplicate classes known error to README.md (flutter/packages#3957)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
Merged
Closed
@reidbaker reidbaker mentioned this pull request Jul 14, 2023
Merged
11 tasks
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@camsim99 @nploi
[camerax] Add Kotlin duplicate classes known error to README.md (flut…
92bf6fe 
…ter#3957)

Adds warning about Kotlin duplicate class error to `README.md`.
@reidbaker reidbaker mentioned this pull request Jul 26, 2023
Merged
11 tasks
@reidbaker reidbaker mentioned this pull request Aug 4, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@gmackall gmackall gmackall approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: camera
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@camsim99 @stuartmorgan-g @gmackall