[url_launcher] Fix Android Java warnings #3690
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
The test here is removing the baseline, which the bot doesn't have a rule for. |
Fixes Android lint warnings found by the `lint-android` repo tool command, and removes the baseline file. Also fixes a few warnings that showed up in Android Studio. Part of flutter/flutter#88011
stuartmorgan-g
force-pushed
the
url-launcher-android-warnings
branch
from
7a70420 to
79166c5
Compare
| @@ -61,6 +62,7 @@ public void onAttachedToActivity(@NonNull ActivityPluginBinding binding) { | |||
| return; | |||
| } | |||
|
|
|||
| assert urlLauncher != null; | |||
There was a problem hiding this comment.
Is this a new Java thing?
There was a problem hiding this comment.
Apparently they are from 1.4, so not so new. I wasn't familiar with them myself, but the AS wizard suggested it as a possible fix for a potential NPE warning, and it seemed like the right thing in this case since it shouldn't be possible for the variable to be null due to the check above for a variable that's constructed from it at the same time that it's set.
stuartmorgan-g
added
the
autosubmit
[url_launcher] Fix Android Java warnings
Fixes Android lint warnings found by the
lint-androidrepo tool command, and removes the baseline file.Also fixes a few warnings that showed up in Android Studio.
Part of flutter/flutter#88011
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).