Skip to content

[video_player] Make video player avfoundation seek to async #3299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gabrielgarciagava
Copy link
Contributor

@gabrielgarciagava gabrielgarciagava commented Feb 25, 2023

This PR is a recreation of flutter/plugins#7164

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gabrielgarciagava gabrielgarciagava changed the title Recreating PR from flutter/plugins: Make video player avfoundation seek to async [video-player] Recreating PR from flutter/plugins: Make video player avfoundation seek to async Feb 25, 2023
@gabrielgarciagava gabrielgarciagava changed the title [video-player] Recreating PR from flutter/plugins: Make video player avfoundation seek to async [video_player] Recreating PR from flutter/plugins: Make video player avfoundation seek to async Feb 25, 2023
Created a single commit for the pigeon upgrade so it is easier to read the second commit
where changes to `message.dart` will be done
@gabrielgarciagava gabrielgarciagava force-pushed the make-video-player-avfoundation-seekTo-async branch from 5789913 to 07f4a80 Compare February 25, 2023 14:16
@gabrielgarciagava
Copy link
Contributor Author

@stuartmorgan Reopened a flutter/plugins PR as suggested.

@gabrielgarciagava gabrielgarciagava force-pushed the make-video-player-avfoundation-seekTo-async branch from 07f4a80 to 277bd6d Compare February 25, 2023 14:57
@stuartmorgan-g stuartmorgan-g changed the title [video_player] Recreating PR from flutter/plugins: Make video player avfoundation seek to async [video_player] Make video player avfoundation seek to async Feb 26, 2023
Copy link
Contributor

@hellohuanlin hellohuanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-stamping from previous PR

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 14, 2023
@BraveEvidence
Copy link

This will help https://www.youtube.com/watch?v=IMQdSTlTXjA

@auto-submit auto-submit bot merged commit 55515f6 into flutter:main Mar 15, 2023
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
…3299)

[video_player] Make video player avfoundation seek to async
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: video_player platform-ios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants